resolving task no.4 with ugly code #22
Conversation
app.js
Outdated
| return convertToHours(getFullTimeOfSleep); | ||
| } | ||
| } | ||
| const getMiliseconds = (h,m) => { |
There was a problem hiding this comment.
Please provide default values, e.g. 0
app.js
Outdated
| const convertedClockStop = clockStop.split(":"); | ||
| const msMotive = convertToMs(convertedMotive[0],convertedMotive[1]); | ||
| const msClockStop = convertToMs(convertedClockStop[0],convertedClockStop[1]); | ||
| const maxNum = Math.max(...[msMotive,msClockStop]); |
There was a problem hiding this comment.
Why create an array and use spread? Math.max(msMotive, msClockStop) would suffice.
app.js
Outdated
| @@ -0,0 +1,34 @@ | |||
| const convertTime = (motiveTime, clockStop, convertToMs, convertToHours) => { | |||
There was a problem hiding this comment.
Good idea with taking output formatter as a function parameter. I'd give it a more meaningful name, though. convertToHours would be named outputFormatter, for example.
| const msClockStop = convertToMs(convertedClockStop[0],convertedClockStop[1]); | ||
| const maxNum = Math.max(...[msMotive,msClockStop]); | ||
| const minNum = Math.min(...[msClockStop,msMotive]); | ||
| if(maxNum && minNum > 0) { |
There was a problem hiding this comment.
What if this condition is evaluated as false? What would be returned then?
| @@ -0,0 +1,34 @@ | |||
| const convertTime = (motiveTime, clockStop, convertToMs, convertToHours) => { | |||
| const convertedMotive = motiveTime.split(":"); | |||
There was a problem hiding this comment.
Variable names don't say much. If I didn't see the values, I wouldn't know what is stored and assigned to them.
app.js
Outdated
| return ((h*60*60+m*60)*1000); | ||
| } | ||
|
|
||
| function timeConversion(millisec) { |
There was a problem hiding this comment.
There would be a better name, e.g. formatTimeToString.
app.js
Outdated
| @@ -0,0 +1,34 @@ | |||
| const convertTime = (motiveTime, clockStop, convertToMs, convertToHours) => { | |||
There was a problem hiding this comment.
The function shouldn't have 4 params
No description provided.